Fix getTableRows to aggregate rows from all DataTable instances#4
Merged
Fix getTableRows to aggregate rows from all DataTable instances#4
Conversation
Previously, getTableRows returned rows from only the first matching DataTable instance, silently dropping rows from other instances of the same table class. When multiple recipes populate the same data table (e.g. ServiceEndpoints from both Java and Node.js discovery), the classToEntityId registry was incomplete, causing CALM relationship entity IDs to remain unresolved.
Member
Author
|
Merged already given the clear issue now that we produce multiple instances of the same data table. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTableRowspreviously returned rows from only the first matchingDataTableinstance, silently dropping rows from other instances of the same table classServiceEndpointsfrom both Java and Node.js discovery), theclassToEntityIdregistry was incomplete, causing CALM relationship entity IDs to remain unresolvedTest plan
GenerateCalmArchitectureTesttests still pass