Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.../openrewrite/java/spring/framework/HttpComponentsClientHttpRequestFactoryConnectTimeout.java
Outdated
Show resolved
Hide resolved
.../openrewrite/java/spring/framework/HttpComponentsClientHttpRequestFactoryConnectTimeout.java
Outdated
Show resolved
Hide resolved
…onnectTimeout The setConnectTimeout method was deprecated in Spring Framework 6.2 and removed in 7.0 because Spring was using deprecated Apache HttpClient5 APIs. This caused issues where the connect timeout would incorrectly become the read timeout when using SSL with connection reuse. The recipe adds a comment directing users to configure the connect timeout on ConnectionConfig on the PoolingHttpClientConnectionManager. Fixes: moderneinc/customer-requests#1751
jkschneider
force-pushed
the
jkschneider/httpcomponents-connect-timeout
branch
from
f3600d9 to
d6109ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpComponentsClientHttpRequestFactoryConnectTimeoutto handle deprecatedsetConnectTimeoutmethodsetConnectTimeouton the factory caused the connect timeout to incorrectly become the read timeout on reused connectionsHttpClientbuilder directlyTest plan
Added unit tests for the new recipe
Verified recipe adds comment without duplicating on subsequent runs
Verified existing
HttpComponentsClientHttpRequestFactoryReadTimeouttests still passFixes: moderneinc/customer-requests#1751