Skip kebab-case conversion for Spring Boot pass-through properties#960
Merged
Skip kebab-case conversion for Spring Boot pass-through properties#960
Conversation
- Simplify path reconstruction: replace ArrayDeque/descendingIterator with List + Collections.reverse for clarity - Add spring.flyway.properties and spring.liquibase.properties to pass-through prefix list - Remove unnecessary exact-match check for prefix key itself
timtebeek
reviewed
Mar 10, 2026
src/main/java/org/openrewrite/java/spring/PassThroughPrefixes.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Mar 10, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PropertiesToKebabCaseYaml incorrectly converts spring.jpa.properties.* keys, breaking Hibernate configuration #957
Properties under known Spring Boot pass-through prefixes (e.g.
spring.jpa.properties.*,spring.kafka.properties.*,spring.quartz.properties.*) are now left unchanged by both the YAML and.propertieskebab-case normalization recipesAdded
PassThroughPrefixesutility class with the list of known pass-through prefixesIn the YAML recipe, the full dotted property path is reconstructed from cursor ancestors to detect pass-through context in nested YAML structures
Test plan
jpaPassThroughPropertiesUnchangedYaml— nested YAML JPA properties remain unchangedjpaPassThroughPropertiesUnchangedProperties— flat.propertiesJPA keys remain unchangedjpaPassThroughButOtherKeysStillConverted— sibling keys likeshowSqlare still converted while pass-through children are preservedkafkaPassThroughPropertiesUnchanged— Kafka pass-through properties remain unchangedquartzPassThroughPropertiesUnchanged— Quartz pass-through properties remain unchangedflatYamlJpaPassThroughUnchanged— flat YAML key with pass-through prefix unchanged