Skip spring-boot-starter-validation when jakarta.validation-api is present#993
Merged
Skip spring-boot-starter-validation when jakarta.validation-api is present#993
Conversation
…esent (#439) Extract AddDependency for spring-boot-starter-validation into a sub-recipe with a ModuleHasDependency precondition (invertMarking) so the starter is not added when the project already declares jakarta.validation-api.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpgradeSpringBoot_2_3no longer addsspring-boot-starter-validationwhen the project already declaresjakarta.validation:jakarta.validation-apiAddDependencystep into a newAddSpringBootStarterValidationsub-recipe with aModuleHasDependencyprecondition usinginvertMarking: truejakarta.validation-apiis presentTest plan
AddsStarterValidationTest.shouldAddValidationStarterIfBVIsUsed— starter still added when no explicit validation API depAddsStarterValidationTest.shouldNotAddValidationStarterIfJakartaValidationApiPresent— starter skipped when jakarta dep presentAddsStarterValidationTest.shouldNotAddValidationStarterIfBVIsNotUsed— starter not added when constraints not used