Fix flyway starter getting explicit version when managed by parent#994
Merged
Fix flyway starter getting explicit version when managed by parent#994
Conversation
MigrateToModularStarters ran before UpgradeParentVersion, so when AddDependency added spring-boot-starter-flyway the parent was still 3.5.x (which doesn't manage that artifact). Move it after the parent/BOM upgrades so the managed version is visible. Fixes openrewrite/rewrite#7307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
MigrateToModularStartersafterUpgradeParentVersioninUpgradeSpringBoot_4_0recipe orderingWhen
MigrateToModularStartersran before the parent upgrade,AddDependencyaddedspring-boot-starter-flywaywith an explicit<version>4.0.5</version>because the parent was still3.5.x(which doesn't manage that artifact). After the parent is upgraded to4.0.x, the version is managed and should be omitted.Add reproducer test: multi-module project with
${revision},spring-boot-starter-parent:3.5.13, andflyway-database-postgresqlin a child moduleFixes ChangeParentPom incorrectly updates child module after update rewrite#7307
Test plan
UpgradeSpringBoot_4_0Test.flywayStarterOmitsVersionWhenManagedByParentfails before fix, passes afterMigrateToModularStartersTest(7 tests) passesRenameDeprecatedStartersManagedVersionsTest(2 tests) passes