Skip adding CrudRepository when already on Spring Data 3.x

[steve-aom-elliott]

Context

• PR Add Spring Data 3.0 upgrade recipe #984 added MigratePagingAndSortingRepository to handle the Spring Data 3.0 change where PagingAndSortingRepository no longer extends CrudRepository. The recipe adds an explicit CrudRepository extends to preserve CRUD methods during migration.

• However, as noted by @DidierLoiseau, the recipe unconditionally adds CrudRepository to any interface extending PagingAndSortingRepository — even for projects already on Spring Data 3.x where omitting CrudRepository may be an intentional design choice.

What this changes

The recipe now checks whether the classpath version of PagingAndSortingRepository still inherits from CrudRepository (i.e., Spring Data 2.x) before making changes. Since this recipe runs before the dependency version upgrade step in UpgradeSpringData_3_0, the type hierarchy on the classpath reflects the pre-migration state:

• Spring Data 2.x: PagingAndSortingRepository extends CrudRepository → recipe fires, adds explicit CrudRepository
• Spring Data 3.x: PagingAndSortingRepository does not extend CrudRepository → recipe is a no-op

This is a single TypeUtils.isAssignableTo check on the resolved PagingAndSortingRepository type itself.

[DidierLoiseau]

Nice! That sounds like a really smart trick! (and also a good compromise to avoid searching for all usages, which could even be outside the current repository when it’s a library)

Also thanks a lot for your reactivity! 🙂

[timtebeek]

Nice! That sounds like a really smart trick! (and also a good compromise to avoid searching for all usages, which could even be outside the current repository when it’s a library)

Also thanks a lot for your reactivity! 🙂

And thank you, as always, for the detailed feedback!