Fix broken Flyway starter test and add Gradle coverage#998
Merged
steve-aom-elliott merged 2 commits intomainfrom Apr 15, 2026
Merged
Fix broken Flyway starter test and add Gradle coverage#998steve-aom-elliott merged 2 commits intomainfrom
steve-aom-elliott merged 2 commits intomainfrom
Conversation
The test had two buildGradle() calls within the same mavenProject, both defaulting to path "build.gradle", causing a source file path collision. The Gradle assertions were also failing because the recipe doesn't modify build.gradle files in a Maven-only project structure. Remove the buildGradle assertions and keep only the Maven-based test, which correctly validates that the Flyway starter gets added.
The original test mixed Maven pomXml and Gradle buildGradle in the same project, which doesn't work. Split the Gradle coverage into its own test method with proper withToolingApi() setup.
steve-aom-elliott
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addFlywayStarterWhenDependencyPresenttest mixed MavenpomXmland GradlebuildGradlesources in the samemavenProject, which doesn't work — a project is either Maven or Gradle, not bothbuildGradle()calls from the Maven test so it tests Maven correctlyaddFlywayStarterWhenGradleDependencyPresenttest with properwithToolingApi()setup, Spring Boot plugin, and a Java source file for theonlyIfUsingpreconditionTest plan
addFlywayStarterWhenDependencyPresentpasses for bothflyway-database-postgresqlandflyway-mysql(Maven)addFlywayStarterWhenGradleDependencyPresentpasses for bothflyway-database-postgresqlandflyway-mysql(Gradle)MigrateToModularStartersTestclass passes