Fix RemoveTryCatchFailBlocks failing when removing blocks within lambda expressions#970
Merged
Fix RemoveTryCatchFailBlocks failing when removing blocks within lambda expressions#970
Conversation
…failing on CI but not locally
timtebeek
added a commit
that referenced
this pull request
Apr 16, 2026
Follow-up to #970, which disabled `doNotChangeAlreadyUnitTestMethods` with comment "flaky on CI but I don't know why". Root cause: as of rewrite 8.79.4 (openrewrite/rewrite#7364), the Kotlin parser maps non-nullable `kotlin.Unit` to JVM `JavaType.Primitive.Void`. `TypeUtils.isOfClassType(type, "kotlin.Unit")` returns false for a primitive, so the recipe no longer skips already-Unit methods and rewrites them unnecessarily — tripping the single-cycle stability check on CI. Locally, stale `rewrite-kotlin` snapshots still carry the pre-change behaviour, which is why the failure was CI-only. Use `KotlinTypeUtils.isKotlinUnit` (introduced in the same PR #7364) which accepts either `JavaType.Primitive.Void` or a `kotlin.Unit` class reference, and re-enable the disabled test.
1 task
timtebeek
added a commit
that referenced
this pull request
Apr 16, 2026
) Follow-up to #970, which disabled `doNotChangeAlreadyUnitTestMethods` with comment "flaky on CI but I don't know why". Root cause: as of rewrite 8.79.4 (openrewrite/rewrite#7364), the Kotlin parser maps non-nullable `kotlin.Unit` to JVM `JavaType.Primitive.Void`. `TypeUtils.isOfClassType(type, "kotlin.Unit")` returns false for a primitive, so the recipe no longer skips already-Unit methods and rewrites them unnecessarily — tripping the single-cycle stability check on CI. Locally, stale `rewrite-kotlin` snapshots still carry the pre-change behaviour, which is why the failure was CI-only. Use `KotlinTypeUtils.isKotlinUnit` (introduced in the same PR #7364) which accepts either `JavaType.Primitive.Void` or a `kotlin.Unit` class reference, and re-enable the disabled test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in flagship recipe runs