Support textBlock attribute in CsvSourceToValueSource#989
Merged
Conversation
Single quote is CsvSource's default quote character, so converting 'apple' to a ValueSource string literal would change the parsed value.
Replaces three local helpers with `StringUtils.containsWhitespace` for the whitespace check and inline `String#indexOf` calls for the single- character checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert
@CsvSource(textBlock = """...""")with a single-column parameter into@ValueSource(...), splitting on newlines and ignoring#comments and blank lines per JUnit's textBlock semantics.Skip when the text block has multiple CSV columns, or when non-String values contain whitespace that would produce invalid Java.
Adds a
Stringcase to the@ValueSourcebuilder so text-block-derived values render as@ValueSource(strings = {...}).Resolves Preserve comments at
csvsourcetovaluesource/ support"""at conversion #985Test plan
./gradlew test --tests CsvSourceToValueSourceTest./gradlew test --tests "org.openrewrite.java.testing.junit5.*"