Annotation Matcher with inner Enums as Attribute Values #4867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butes are not detectable by AnnotationMatchers
timtebeek
changed the title
Contributor
|
This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Application Frameworks like Spring often user enums for annotation attributes to restrict the possible values.
Often these enums are defined within the annotation class itself as inner enums.
Traits canot work 100% in this cases.
Anything in particular you'd like reviewers to focus on?
There is a new ToDo this line is the problem.
The root problem seems to be that the type of FieldAccess for inner enums is not set correctly.
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Add adtional checks in the visitor methods.
Any additional context
Checklist