no precondition data tables #5248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Precondition recipes must not produce data table rows When a recipe is used as a precondition of another recipe, it must not produce any data table rows. Only the recipes which are executed by the recipe scheduler must produce data table rows. * Declare `DataTable#recipe` as transient * Small fixes * Polish * Remove some hacks * Another indirection for built-in data tables * Support RPC * Polish (cherry picked from commit 48784bb)
When a recipe is used as a precondition of another recipe, it must not produce any data table rows. Only the recipes which are executed by the recipe scheduler must produce data table rows. The original take on this (#5228) didn't work properly, because of how declarative recipes with preconditions have been implemented as classes implementing the `DelegatingRecipe` interface, where the recipe being executed by the recipe scheduler is a wrapper for the actual recipe.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.