Break cycles when parsing Gradle projects. #6666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle doesn't allow cyclic dependencies... usually. But we've found at least one case where, with some creative usage of composite builds, it is possible. This breaks cycles in the dependency representation, preserving the evidence in the GradleConfiguration's exception fields.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| import java.util.*; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; |
Contributor
There was a problem hiding this comment.
Suggested change
| import static org.assertj.core.api.Assertions.assertThat; | |
| import static java.util.Collections.emptySet; | |
| import static org.assertj.core.api.Assertions.assertThat; |
...ooling-model/model/src/test/java/org/openrewrite/gradle/marker/GradleProjectBuilderTest.java
Outdated
Show resolved
Hide resolved
shanman190
reviewed
Feb 3, 2026
| if (resolvedDependency == null) { | ||
| org.openrewrite.maven.tree.Dependency requested = gaToRequested.getOrDefault(ga, dependency(resolved)); | ||
| // Track the traversal path to detect cycles at any depth | ||
| List<GroupArtifactVersion> ancestorPath = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
A HashSet would probably be a bit quicker and gives the same uniqueness constraint while also having the helpful boolean add(T) method.
I'm also not sure if we actually need to track version, but it won't hurt. Gradle's dependency tree puts the max version everywhere by the time we get to traverse it.
Member
Author
There was a problem hiding this comment.
HashSet loses order so we couldn't reproduce the A -> B -> C -> A as easily for meaningful error message. Could use LinkedHashSet, though
Contributor
There was a problem hiding this comment.
I see, I see. It probably isn't worth it then in that case.
…te/gradle/marker/GradleProjectBuilderTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle doesn't allow cyclic dependencies... usually. But we've found at least one case where, with some creative usage of composite builds, it is possible.
This breaks cycles in the dependency representation, preserving the evidence in the GradleConfiguration's exception fields.