Python: Fix f-string parsing for debug = with format spec#6731
Merged
knutwannheden merged 1 commit intomainfrom Feb 13, 2026
Merged
Python: Fix f-string parsing for debug = with format spec#6731knutwannheden merged 1 commit intomainfrom
knutwannheden merged 1 commit intomainfrom
Conversation
When an f-string uses the debug specifier `=` combined with a format
spec but no conversion (e.g. `{last_error=:#x}`), the `:` token was
not advanced past before parsing the format spec. This caused the
format spec parser to consume `:` instead of the actual format text,
leaving the FSTRING_MIDDLE token unconsumed and the parser stuck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{var=:#x}(debug=+ format spec, no conversion):token was not advanced past before parsing the format spec, causing the parser to get stuck{var=:fmt}patternsTest plan
test_debug_with_format_specpassesstreamlink/src/streamlink_cli/console/windows.py