Python: Fix ty 0.0.18 type checking diagnostics#6806
Merged
knutwannheden merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
Add targeted `# ty: ignore` suppressions with issue references for known ty limitations and structural Python constraints. Key changes: - Add `replace()` to `J` base class in `.pyi` stub (fixes ~20 errors) - Add `@dataclass` to `Union`/`Intersection` in stubs (fixes 5 errors) - Remove obsolete `# ty: ignore` comments no longer needed - Add per-line suppressions referencing ty#628, ty#2193 where applicable 28 diagnostics remain in `type_mapping.py` due to JavaType inner class hierarchy not being expressible in Python (metaclass conflict between ABC and Enum prevents inner classes from extending enclosing class).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# ty: ignoresuppressions with issue references for known ty limitations and structural Python constraintsreplace()method declaration toJbase class in.pyistub, fixing ~20unresolved-attributeerrors where frozen dataclassreplace()was not visible on abstract base types@dataclassdecorator toUnionandIntersectionin.pyistub, fixing 5unknown-argumenterrors for_boundsparameter# ty: ignorecomments that are no longer needed with ty 0.0.1828 diagnostics remain in
type_mapping.py— these are due to a structural Python limitation where JavaType inner classes cannot extend the enclosingJavaTypeclass (metaclass conflict betweenABCMetaandEnumMetaforPrimitive).Test plan
ty checkshows 0 new diagnostics (28 remaining are pre-existingtype_mapping.pylimitation)