UpgradePluginVersion: skip adding version when managed by pluginManagement#6828
Open
UpgradePluginVersion: skip adding version when managed by pluginManagement#6828
Conversation
…nagement When `addVersionIfMissing` is true, `UpgradePluginVersion` now checks whether the plugin already has a version managed via `<pluginManagement>` (local or inherited from a parent POM) before adding an explicit `<version>` tag. This prevents unwanted version additions in child modules that inherit their plugin version from a parent. Fixes openrewrite/rewrite-migrate-java#992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
addVersionIfMissingis true,UpgradePluginVersionnow checks whether the plugin already has a version managed via<pluginManagement>(local or inherited from a parent POM) before adding an explicit<version>tagThis prevents unwanted version additions in child modules that inherit their plugin version from a parent
Uses the same
pluginManagementlookup pattern asRemoveRedundantDependencyVersions.getManagedPluginVersion()Fixes After upgrading
rewrite-migrate-javafrom 3.27.1 to 3.28.0 openrewrite keeps addingversionelement even if the one is managed in the parent rewrite-migrate-java#992Follows Add maven-compiler-plugin version when missing during Java migration rewrite-migrate-java#989 (comment)
Test plan
shouldNotAddVersionWhenManagedByParenttest verifying no<version>is added to a child module when the parent's<pluginManagement>manages the plugin versionUpgradePluginVersionTesttests passJava8toJava11Testinrewrite-migrate-javapasses (usesaddVersionIfMissing: trueformaven-compiler-plugin)