JavaScript: Fix stack overflow in Type.signature for cyclic parameterized types#6867
Merged
knutwannheden merged 1 commit intomainfrom Mar 4, 2026
Merged
JavaScript: Fix stack overflow in Type.signature for cyclic parameterized types#6867knutwannheden merged 1 commit intomainfrom
Type.signature for cyclic parameterized types#6867knutwannheden merged 1 commit intomainfrom
Conversation
The Parameterized case in signature() was missing a cycle detection check that the Union and Intersection cases already had. When shell-cached parameterized types formed cycles (e.g. A<B<A>>), the function would recurse infinitely. This was triggered by google/zx during Moderne builds.
Type.signature for cyclic parameterized types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parameterizedcase inType.signature()was missing ahas()cycle detection check before recursing into type parameters. TheUnionandIntersectioncases already had this guard, butParameterizeddid not.A<B<A>>), the function recursed infinitely, causingRangeError: Maximum call stack size exceededduring RPC serialization.Test plan