Use long in Semver.max() for large version segments#6952
Merged
Conversation
Completes the int-to-long migration in the semver package. TildeRange, CaretRange, and LatestRelease already use long; Semver.max() was the last holdout using Integer.parseInt, which would still throw for date-based version segments like 202302104298.
Contributor
Author
|
@timtebeek this was not covered by (as it was not needed for that particular recipe failure) |
timtebeek
approved these changes
Mar 12, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TildeRange,CaretRange, andLatestRelease.compare()already uselong;Semver.max()was the last method usingInteger.parseInt, which would throwNumberFormatExceptionfor date-based version segments like202302104298.