C#: Fix incomplete visitor traversal in JavaVisitor.cs and CSharpVisitor.cs#6970
Merged
knutwannheden merged 2 commits intomainfrom Mar 12, 2026
Conversation
Visit ALL tree-typed properties in model order for every Visit* method. Add VisitExpression/VisitStatement interception hooks matching the Java reference, and VisitType calls for JavaType-typed properties. Add Accept dispatch for NamedVariable, If.Else, ForLoop.Control, ForEachLoop.Control, and Lambda.Parameters.
Every Visit* method now: - Calls VisitStatement/VisitExpression interception hooks matching the type's interface hierarchy (Statement first, then Expression) - Visits ALL tree-typed properties in constructor parameter order - Checks nullability before visiting nullable properties - Calls VisitType for all JavaType? properties at the end Previously many methods were missing interception hooks, skipping properties, or were stubs that returned the input unchanged.
knutwannheden
deleted the
fix-incomplete-visitor-traversal-in-javavisitor.cs-and-csharpvisitor.cs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaVisitor.cs— everyVisit*method now visits ALL tree-typed properties in model orderVisitExpression,VisitStatement, andVisitTypeinterception hooks matching the Java referenceNamedVariable,If.Else,ForLoop.Control,ForEachLoop.Control, andLambda.ParametersVisitTypefor allJavaType-typed properties at the end of each visitor methodTest plan
dotnet buildpassesdotnet testpasses