Fix BatchVisit over-attributing RecipesThatMadeChanges marker#6987
Merged
knutwannheden merged 1 commit intomainfrom Mar 16, 2026
Merged
Fix BatchVisit over-attributing RecipesThatMadeChanges marker#6987knutwannheden merged 1 commit intomainfrom
BatchVisit over-attributing RecipesThatMadeChanges marker#6987knutwannheden merged 1 commit intomainfrom
Conversation
flushBatch unconditionally added all recipes in the batch to the RecipesThatMadeChanges marker when any recipe modified the tree. Now only recipes whose BatchVisitResult.modified is true get attributed.
knutwannheden
changed the title
BatchVisit over-attributing RecipesThatMadeChanges marker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flushBatchunconditionally added all recipes in a batch to theRecipesThatMadeChangesmarker when any recipe modified the tree. A batch of 10 recipes where only 1 made changes would incorrectly attribute all 10.BatchVisitResult.modifiedis true get added to the marker.Test plan
batchOnlyAttributesRecipesThatActuallyMadeChangestest inRewriteRpcTestthat creates a batch of 3 RPC recipes (ChangeText, Find with no match, ChangeText) and asserts onlyChangeTextappears in the markerRewriteRpcTesttests pass