Add CSharpPattern capture support tests for as operator#6999
Merged
knutwannheden merged 1 commit intomainfrom Mar 17, 2026
Merged
Add CSharpPattern capture support tests for as operator#6999knutwannheden merged 1 commit intomainfrom
CSharpPattern capture support tests for as operator#6999knutwannheden merged 1 commit intomainfrom
Conversation
The `as` operator already works with CSharpPattern via CsBinary matching, but lacked test coverage for capture-based patterns. Add tests for captures on both sides, left-only, right-only, and a negative test confirming `as` patterns don't match `is` expressions. Also add the missing FindCsBinary(TemplateStringHandler) helper overload.
knutwannheden
changed the title
as operatorCSharpPattern capture support tests for as operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asoperator already works withCSharpPatternviaCsBinarymatching, but lacked test coverage for capture-based patternsFindCsBinary(TemplateStringHandler)helper overload to enable capture-based test patternsaswith captures on both sides, left-only, right-only, and a negative test confirmingaspatterns don't matchisexpressionsTest plan
as-related pattern match tests pass (1 existing + 4 new)