C#: Deduplicate TargetFrameworks list after replacement#7149
Merged
knutwannheden merged 1 commit intomainfrom Mar 26, 2026
Merged
C#: Deduplicate TargetFrameworks list after replacement#7149knutwannheden merged 1 commit intomainfrom
knutwannheden merged 1 commit intomainfrom
Conversation
When multiple TFMs in a `<TargetFrameworks>` list independently map to the same new TFM (e.g. via chained upgrade recipes), the result contained duplicates. Use a LinkedHashSet to preserve order while eliminating duplicates after replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a
.csprojhas multiple TFMs that independently map to the same target through chained upgrade recipes (e.g.UpgradeToDotNet10),ChangeDotNetTargetFrameworkproduces duplicates in the<TargetFrameworks>list. For example,net40;netstandard2.0;net6.0becomesnet40;net10.0;net10.0instead ofnet40;net10.0.Summary
StringBuilder-based loop with aLinkedHashSetto collect frameworks after replacement, preserving order while deduplicatingTest plan
deduplicatesMultiTfmAfterReplacementverifiesnet40;netstandard2.0;net6.0→net40;net6.0when replacingnetstandard2.0withnet6.0ChangeDotNetTargetFrameworkTesttests pass