Treat missing POMs for non-classpath dependencies as warnings#7163
Merged
Treat missing POMs for non-classpath dependencies as warnings#7163
Conversation
Maven itself only logs a warning when a dependency's POM cannot be
downloaded ("The POM for ... is missing, no dependency information
available") and continues the build. Our resolution was treating this
as a fatal error, causing the entire LST build to fail when e.g. tgz
dependencies lack a POM in the repository.
For non-classpath artifact types (tgz, zip, pom, bom), skip the
dependency on download failure instead of accumulating a fatal
exception, matching Maven's behavior.
Fixes moderneinc/customer-requests#2095
timtebeek
approved these changes
Mar 27, 2026
Member
timtebeek
left a comment
timtebeek
left a comment
There was a problem hiding this comment.
Makes sense; thanks for linking the sources as well.
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
sambsnyd
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The POM for ... is missing, no dependency information available) and continues the build. Our dependency resolution was treating this as a fatalMavenDownloadingExceptions, causing the entire LST build to fail.tgz,zip), we now skip the dependency on download failure instead of failing, matching Maven's behavior.References
Test plan
unresolvableTgzDependencyShouldNotFailBuildtest that verifies tgz dependencies with unreachable POMs don't produce aParseExceptionResultsiblingDependencyWithTgzPackagingAndSnapshottest still passes (tgz deps with available POMs still resolve)rewrite-maventest suite passes