Skip to content

Write data table headers using column descriptor names not display names#7167

Merged
bryceatmoderne merged 1 commit intomainfrom
write-dt-columns-using-name
Mar 27, 2026
Merged

Write data table headers using column descriptor names not display names#7167
bryceatmoderne merged 1 commit intomainfrom
write-dt-columns-using-name

Conversation

@bryceatmoderne
Copy link
Copy Markdown
Contributor

@bryceatmoderne bryceatmoderne commented Mar 26, 2026

What's changed?

CsvDataTableStore#createBucketWriter was building data table headers using ColumnDescriptor.displayName not ColumnDescriptor.name which regresses previous behaviour.

What's your motivation?

Data tables written by Moderne's CLI were using a mix of data table names and displayNames.

Anything in particular you'd like reviewers to focus on?

No.

Anyone you would like to review specifically?

@jkschneider

Have you considered any alternatives or workarounds?

No.

Any additional context

No.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Mar 27, 2026
@bryceatmoderne bryceatmoderne merged commit a55b907 into main Mar 27, 2026
1 check passed
@bryceatmoderne bryceatmoderne deleted the write-dt-columns-using-name branch March 27, 2026 13:37
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants