Write data table headers using column descriptor names not display names#7167
Merged
bryceatmoderne merged 1 commit intomainfrom Mar 27, 2026
Merged
Write data table headers using column descriptor names not display names#7167bryceatmoderne merged 1 commit intomainfrom
bryceatmoderne merged 1 commit intomainfrom
Conversation
timtebeek
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
CsvDataTableStore#createBucketWriterwas building data table headers usingColumnDescriptor.displayNamenotColumnDescriptor.namewhich regresses previous behaviour.What's your motivation?
Data tables written by Moderne's CLI were using a mix of data table names and displayNames.
Anything in particular you'd like reviewers to focus on?
No.
Anyone you would like to review specifically?
@jkschneider
Have you considered any alternatives or workarounds?
No.
Any additional context
No.
Checklist