C#: Unwrap parentheses in pattern matching comparator#7188
Merged
knutwannheden merged 1 commit intomainfrom Mar 28, 2026
Merged
C#: Unwrap parentheses in pattern matching comparator#7188knutwannheden merged 1 commit intomainfrom
knutwannheden merged 1 commit intomainfrom
Conversation
Patterns like `Console.WriteLine("hello")` now match candidates with
extra parentheses like `Console.WriteLine(("hello"))`, and a
parenthesized pattern `(x + 1)` matches the unparenthesized `x + 1`.
Adds a non-generic `Parentheses` interface (extending `Expression`) so
that `Parentheses<T>` can be unwrapped with a simple `is` check — no
reflection needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The C# pattern matcher (
PatternMatchingComparator) did not ignore optional expression parentheses, so a pattern likeConsole.WriteLine("hello")would fail to matchConsole.WriteLine(("hello")), and a parenthesized pattern(x + 1)wouldn't match the unparenthesizedx + 1. The JavaScript comparator already handles this via anunwrap()step — this brings parity to C#.Summary
Parenthesesinterface (extendingExpression) with anInnerTreeproperty, soParentheses<T>can be type-checked and unwrapped without reflectionParentheses<T>now implements the non-genericParenthesesinterfacePatternMatchingComparator.UnwrapParentheses()recursively stripsParentheseswrappers using a simplewhile (node is Parentheses p)loopMatchNodeand in the fast-reject path inCSharpPattern.MatchTest plan
MatchesConcreteArgThroughParentheses— pattern without parens matches candidate arg wrapped in parensParenthesizedPatternMatchesUnparenthesized— parenthesized pattern(x + 1)matchesx + 1PatternMatchTestspass (no regressions)