Skip to content

JavaScript: setting RPC metrics file in debugging mode too#7201

Merged
greg-at-moderne merged 1 commit intomainfrom
greg-js-recipeCsvMetrics-in-debugging
Mar 30, 2026
Merged

JavaScript: setting RPC metrics file in debugging mode too#7201
greg-at-moderne merged 1 commit intomainfrom
greg-js-recipeCsvMetrics-in-debugging

Conversation

@greg-at-moderne
Copy link
Copy Markdown
Contributor

@greg-at-moderne greg-at-moderne commented Mar 30, 2026

What's changed?

Making sure the RPC calls with debug enabled also have RPC metrics collected to a CSV file, as the normal runs do.

What's your motivation?

  • I've just spent 2 hours looking at the wrong files when debugging an issue, when I was kind of assuming the newest metrics.csv reflects what happened in the latest RPC run.
  • I don't see a reason not to have this file produced. This is some rare path (debug enabled) anyway.

@greg-at-moderne greg-at-moderne self-assigned this Mar 30, 2026
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Mar 30, 2026
@greg-at-moderne greg-at-moderne marked this pull request as ready for review March 30, 2026 15:07
@greg-at-moderne greg-at-moderne merged commit ca1dabb into main Mar 30, 2026
1 check passed
@greg-at-moderne greg-at-moderne deleted the greg-js-recipeCsvMetrics-in-debugging branch March 30, 2026 15:07
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant