Gracefully handle malformed Maven version strings#7234
Merged
Conversation
Fix NumberFormatException when encountering malformed version strings like `-captain-daily-SNAPSHOT` in Maven repository metadata. Fixes #7233
Jenson3210
approved these changes
Apr 1, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-captain-daily-SNAPSHOTin Maven repository metadata caused aNumberFormatExceptionduring dependency resolution.Two fixes applied: (1) the
Versiontokenizer's empty-token fallback now treats the token as a string qualifier instead of a number, preventing the crash at the source; (2)VersionRequirement.cacheResolved()catchesIllegalArgumentExceptionfromnew Version()and skips malformed versions, as a safety net for any other unforeseen parsing edge cases.Test plan
VersionTest:new Version("-captain-daily-SNAPSHOT")andnew Version("-")no longer throwVersionRequirementTest: version range resolution succeeds when available versions include malformed strings