XmlParser: case-insensitive accept for nuget.config#7317
Merged
Conversation
…in XmlParser The XmlParser.accept() method used Path.endsWith() which is case-sensitive, so files like NuGet.config or Packages.config were not recognized as XML and fell through to the PlainTextParser. Switch to equalsIgnoreCase on the file name to handle all casing variants.
Apply toLowerCase() to the extracted extension before checking against the accepted set, so files like foo.XML or proj.Csproj are correctly recognized.
steve-aom-elliott
added
enhancement
timtebeek
approved these changes
Apr 8, 2026
Member
|
I'd be shouting too if I had to use Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XmlParser.accept() had two case-sensitivity issues:
File extensions: The extension check used a case-sensitive Set.contains(), so files like
foo.XMLorproj.Csprojwere not recognized as XML. Added toLowerCase() on the extracted extension before lookup.Config file names: The nuget.config and packages.config checks used Path.endsWith() which is case-sensitive, so
NuGet.configorPackages.configfell through to PlainTextParser. Switched to String.equalsIgnoreCase() on the file name.Added test cases for mixed-case extensions and config file names.