Parse all requirements files in requirements-only Python projects#7323
Merged
Parse all requirements files in requirements-only Python projects#7323
Conversation
Previously parseManifest only picked the first matching requirements file via findFirst(). Projects with multiple requirements files (e.g. requirements.txt, requirements-dev.txt) would only have one file with a PythonResolutionResult marker, so dependency recipes like FFVD could not operate on the others. Closes moderneinc/customer-requests#2157
sambsnyd
approved these changes
Apr 8, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
timtebeek
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseManifestpreviously used.findFirst()to pick only one requirements file, ignoring others likerequirements-dev.txtChanged to collect and parse all matching requirements files, each receiving its own
PythonResolutionResultmarkerAdded integration test verifying multiple requirements files get distinct markers
Closes moderneinc/customer-requests#2157
Test plan
includesAllRequirementsTxtFilesintegration test passes — verifies bothrequirements.txtandrequirements-dev.txtare parsed with distinctPythonResolutionResultmarkers pointing to their respective pathsincludesRequirementsTxtandpyprojectTomlTakesPriorityOverRequirementsTxttests still pass