RequirementsTxtParser: surface resolution failures as ParseExceptionResult#7326
Merged
Jenson3210 merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
Surface failures (non-PlainText input, workspace creation failure, empty freeze output) as ParseExceptionResult markers instead of silently returning the source file unchanged, so users can diagnose why no PythonResolutionResult was produced.
timtebeek
approved these changes
Apr 9, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attach a
ParseExceptionResultmarker whenRequirementsTxtParsercannot produce aPythonResolutionResult(non-PlainText input, workspace creation failure, or empty freeze output) instead of silently returning the source file unchanged.Add a test covering the unresolvable-requirements path.
Links: moderneinc/customer-requests#2185
Test plan
./gradlew :rewrite-python:test --tests "*RequirementsTxtParserTest*"