JavaScript: fail fast if no codec for Json.Document#7359
Merged
greg-at-moderne merged 1 commit intomainfrom Apr 14, 2026
Merged
JavaScript: fail fast if no codec for Json.Document#7359greg-at-moderne merged 1 commit intomainfrom
greg-at-moderne merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
A safety mechanism for JavaScript RPC.
Explicitly fail to start the
JavaSciptRewriteRpcif the Java side doesn't have a codec for JSON.What's your motivation?
This has affected Moderne CLI around version 4.1.3, leading to weird and hard-to-diagnose problems running JS recipes. The errors included:
With this safety mechanism, it'd still fail, but at least explicitly with clear indication of what's wrong.