Fix NPE in ChangeDependencyGroupIdAndArtifactId for POMs without dependencyManagement#7374
Merged
Fix NPE in ChangeDependencyGroupIdAndArtifactId for POMs without dependencyManagement#7374
Conversation
…dencyManagement Pom fields use @Builder.Default to initialize to emptyList(), but deserialization can bypass the builder and leave them null. Guard against null getDependencyManagement() and getDependencies() in MavenDependencyPropertyUsageOverlap and both getSafeVersionPlaceholdersToChange methods in ChangeDependencyGroupIdAndArtifactId.
Contributor
Author
|
merging this after in person discussion with tim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pomfields use@Builder.Defaultto initialize list fields toemptyList(), but deserialization can bypass the builder and leave themnullChangeDependencyGroupIdAndArtifactIdcrashes with NPE when run against a POM that has no<dependencyManagement>sectionMavenDependencyPropertyUsageOverlap.filterPropertiesWithOverlapInDependencies()— guards bothgetDependencyManagement()andgetDependencies()getSafeVersionPlaceholdersToChange()methods inChangeDependencyGroupIdAndArtifactId— guardsgetDependencies()Test plan
noDependencyManagementSection()test that runsChangeDependencyGroupIdAndArtifactIdon a POM with no<dependencyManagement>section./gradlew :rewrite-maven:test --tests "*ChangeDependencyGroupIdAndArtifactId*"