Detect cyclic property references instead of StackOverflowError#7396
Merged
Detect cyclic property references instead of StackOverflowError#7396
Conversation
When Maven properties form a cycle (e.g. <revision>${revision}</revision>,
or <revision>${project.build.version}</revision> with
<project.build.version>${revision}</project.build.version>),
PropertyPlaceholderHelper.parseStringValue() recursed infinitely on
line 150, producing a StackOverflowError.
The existing visited-placeholder tracking only guarded key resolution
(nested placeholder keys like ${${foo}}), but not value resolution.
When a resolved value contained a placeholder already being resolved,
the value-resolution path on line 150 re-entered parseStringValue
without any cycle check, creating infinite recursion.
When a placeholder is already in the visited set, skip its resolution
entirely and leave it unresolved in the output. This matches the
existing cycle-detection intent while covering the value-resolution
path that was previously unguarded.
sambsnyd
approved these changes
Apr 16, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / problem
When Maven properties form a cycle (e.g.
<revision>${revision}</revision>, or a two-hop cycle like<revision>${project.build.version}</revision>with<project.build.version>${revision}</project.build.version>),PropertyPlaceholderHelper.parseStringValue()produces aStackOverflowError. This crashes the Moderne CLI during its POM pre-parsing step before Maven is even invoked.The existing visited-placeholder tracking only guarded key resolution (nested placeholder keys like
${${foo}}), but not value resolution. When a resolved value contained a placeholder already being resolved, the value-resolution path re-enteredparseStringValuewithout any cycle check, creating infinite recursion.Solution
When a placeholder is already in the visited set, skip its resolution entirely and leave it unresolved in the output. This matches the existing cycle-detection intent while covering the value-resolution path that was previously unguarded.
Test plan
PropertyPlaceholderHelperTest.selfReferencingPropertyDoesNotStackOverflow-- direct self-referencePropertyPlaceholderHelperTest.cyclicPropertyReferenceDoesNotStackOverflow-- two-hop cycleMavenParserTest.selfReferencingPropertyDoesNotStackOverflow-- full Maven parseMavenParserTest.cyclicPropertyReferenceDoesNotStackOverflow-- multi-module POM cyclecircularMavenProperty,circularProjectVersionReference, etc.)mod buildno longer StackOverflows on reproducer repos