Fix/change method target to static constructor wildcard#7399
Merged
timtebeek merged 3 commits intoopenrewrite:mainfrom Apr 16, 2026
Merged
Conversation
…s on wildcard method patterns
Member
|
Yes makes sense; thanks for the immediate fix @kdvolder ! |
timtebeek
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a guard clause to
ChangeMethodTargetToStatic.visitNewClassso it only transforms constructors into static method calls when the method pattern explicitly targets a constructor (e.g., using<constructor>or<init>).What's your motivation?
This fixes a bug where
ChangeMethodTargetToStaticwas incorrectly matching and transforming allnewobject creations when provided with a broad wildcard method pattern like*(..). This broke declarative recipes that used wildcards to match all methods on a class.Anything in particular you'd like reviewers to focus on?
Have you considered any alternatives or workarounds?
An alternative would be changing
MethodMatcheritself so that the*wildcard does not match<init>, but that would be a much larger breaking change to core matching behavior that has been in place since 2022.Checklist