Scala: public canonical ctors for S.TuplePattern and S.FunctionCall#7462
Merged
knutwannheden merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
…and `S.FunctionCall` Both classes previously exposed only a private `@AllArgsConstructor`-generated canonical constructor whose first parameter is the padding `WeakReference`. Deserializers (such as moderne-ast-write's V3 codegen) skip non-public constructors and constructors that take a `WeakReference`, so these types were invisible to static codegen and fell through to the dynamic-schema read path — where, lacking any other public constructor, construction failed and source files were substituted with a `Quark` + `DeserializationError` marker. Adding `@RequiredArgsConstructor` generates a public canonical constructor that excludes the `@NonFinal` padding field, matching the pattern already used by `S.CompilationUnit` and by rewrite-java types such as `J.MethodInvocation`. The private padding-aware constructor remains for internal use.
knutwannheden
changed the title
S.TuplePattern and S.FunctionCallS.TuplePattern and S.FunctionCall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
S.TuplePatternandS.FunctionCallpreviously exposed only a private@AllArgsConstructor-generated canonical constructor whose first parameter is the paddingWeakReference.Summary
@RequiredArgsConstructortoS.TuplePatternandS.FunctionCall, alongside the existing@AllArgsConstructor(access = AccessLevel.PRIVATE).paddingfield is@NonFinal,@RequiredArgsConstructorexcludes it — generating a public canonical constructor that omits theWeakReference, exactly matching the pattern used byS.CompilationUnitin the same file and by rewrite-java types such asJ.MethodInvocation.org.openrewrite.scala.tree.*package: the remaining 6 final tree classes (CompilationUnit,Wildcard,StatementExpression,TypeAscription,TypeAlias,PatternDefinition) already have a public canonical constructor — either via@RequiredArgsConstructoror hand-written — so no further changes are needed.Test plan
./gradlew :rewrite-scala:compileJavasucceeds.