Fix GroovyParserVisitor crash on multi-variable field declarations#7467
Merged
Fix GroovyParserVisitor crash on multi-variable field declarations#7467
Conversation
Groovy emits a separate `FieldNode` for each variable in a multi-variable field declaration (e.g., `final String a, b`). The parser was treating each one as a complete declaration and re-consuming the modifiers and type tokens, desynchronizing the cursor and eventually throwing `StringIndexOutOfBoundsException` when parsing later nodes. Detect continuation fields in `visitVariableField` and emit a `MultiVariable` marker with an empty type expression, mirroring the existing handling for local multi-variable declarations like `def a = 1, b = 2`.
Call it through the existing `visitor` instance from `visitVariableField` to avoid displacing the `sourceBefore` javadoc.
greg-at-moderne
approved these changes
Apr 23, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
iw2rmb
pushed a commit
to iw2rmb/rewrite
that referenced
this pull request
Apr 24, 2026
Comparison-only alternative to openrewrite#7467: parse grouped field declarations as a single declaration to avoid cursor drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FieldNodefor each variable in a multi-variable field declaration (e.g.,final String a, b), butvisitVariableFieldwas treating each one as a complete declaration and re-consuming the modifiers and type tokens. This desynchronized the cursor and eventually crashed withStringIndexOutOfBoundsExceptionwhen parsing later nodes.The fix detects continuation fields at a leading
,and emits aMultiVariablemarker with an empty type expression, mirroring the existing handling for local multi-variable declarations likedef a = 1, b = 2.Test plan
./gradlew :rewrite-groovy:testpassesfinal String a, band initializer variants inVariableDeclarationsTestConstructorTest