JavaScript: Package Manager to return the same node resolution marker if no changes#7473
Merged
greg-at-moderne merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Additional check at the end of the JavaScript's Package Manager logic to return the same input doc, if the node resolution marker is equal to the original one.
What's your motivation?
This way we prevent a no-op change, which I ran into one of the recipes in the derived projects. The test suddenly started failing after #6904 got merged. That PR added more assertions to the tests. That's how it got discovered.