Improve AddDependency performance by reducing unnecessary scanning for types in use#7482
Merged
Improve AddDependency performance by reducing unnecessary scanning for types in use#7482
Conversation
sambsnyd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once AddDependency finds a type it is looking for stop scanning other files in the same source set.
Data shows that 38% of the time spent on a large spring boot upgrade recipe is spent on AddDependency and up to 99% of that is in the scanning phase. The only thing in the scanning phase which could take so much time is the "onlyIfUsing" calculation.