Make Java compatibility tests not depend on java-tck JAR#7489
Merged
greg-at-moderne merged 1 commit intomainfrom Apr 28, 2026
Merged
Make Java compatibility tests not depend on java-tck JAR#7489greg-at-moderne merged 1 commit intomainfrom
greg-at-moderne merged 1 commit intomainfrom
Conversation
Member
|
Similarly I see this PR still triggered these two tasks; was that expected & necessary? |
Contributor
Author
|
No it wasn't. That's another problem of the same kind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Changing the internal Gradle configuration of Java compatibility tests.
Namely, the various Java version tests (8, 11, 17, 21, 25) when depending on java-tck, now they depend on the class files of that module, not a jar. JAR is not deterministic and prevents Gradle caching (unless some tricks are applied there).
What's your motivation?
Speed up CI in this project. These Java compatibility tests have no need to run in every single PR. They are bound to give the same output if nothing changed in the chain.