Add Maven recipes for reproducible builds#7541
Merged
Conversation
Introduces a `ReproducibleBuilds` composite that sets `project.build.outputTimestamp`, enforces UTF-8 source/reporting encoding, and upgrades Apache Maven plugins to versions that honor the output timestamp. Existing values are preserved.
Removes the standalone AddSourceEncodingProperty and UpgradePluginVersionsForReproducibleBuilds wrappers and inlines their content directly in ReproducibleBuilds. ReproducibleBuildsTest still exercises the full behavior end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
org.openrewrite.maven.ReproducibleBuildscomposite that configures a Maven project per the Maven Reproducible Builds guide: pins dependency and plugin versions (via existingExplicitDependencyVersion/ExplicitPluginVersion), setsproject.build.outputTimestamp(default1980-01-01T00:00:00Z, configurable), adds explicit UTF-8 source and reporting encoding, and upgrades Apache Maven plugins to versions that honor the output timestamp.Introduces three new declarative recipes —
AddSourceEncodingProperty,UpgradePluginVersionsForReproducibleBuilds,ReproducibleBuilds— and one Java recipe,AddProjectBuildOutputTimestamp, which delegates to the existingAddPropertyand preserves any pre-existing value.Test plan
./gradlew :rewrite-maven:test --tests "*AddProjectBuildOutputTimestampTest" --tests "*AddSourceEncodingPropertyTest" --tests "*ReproducibleBuildsTest"— 8 tests pass./gradlew :rewrite-maven:licenseFormat :rewrite-maven:assemble