Scala: add support for parsing primary-constructor parameters#7643
Merged
Conversation
Fixes regression caught by IdentifierTest.backtickIdentifierAcrossContexts (added on main in 73358e5 after this branch forked): `case class CC(`type`: String)` lost its closing backtick because vd.name.toString strips backticks and vd.nameSpan covers only the raw identifier.
greg-at-moderne
force-pushed
the
greg-scala-ctor-params-rich-types
branch
from
75b931d to
ad3b8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Fix Scala parser to support primary-constructor parameters, e.g.
class Greeter(name: String = "world")What's your motivation?
It's not supported right now, some idempotency failures are observed.