JavaScript: make prettier a devDependency to fix flaky npmBuild#7735
Merged
Conversation
…s on npm honoring the optional install
`prettier` was in `optionalDependencies` only. npm normally installs
optional deps, but silently skips them on any transient install failure
(registry blip, integrity retry, etc.). When that happened on a CI
runner, `tsc --build` failed with TS2307 because the source uses
`typeof import('prettier')` and needs the types at compile time.
Keep `prettier` in `optionalDependencies` too — that's how end-user
installs of `@openrewrite/rewrite` still pull prettier in by default
(with the existing bundled-prettier fallback if they skip it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:rewrite-javascript:npmBuildfailed on main with 9TS2307: Cannot find module 'prettier'errors (run 26104109474).prettierwas inoptionalDependenciesonly. npm normally installs optional deps, but silently skips them on transient install failures. The successful run earlier the same day installed 81 packages in 29s; the failing run installed 80 in 45s — prettier was the one quietly dropped. Reproducible locally withrm -rf node_modules/prettier && npm run build.prettierindevDependenciesso it's always installed for the build. Kept it inoptionalDependenciesso end-user installs of@openrewrite/rewritestill pull it in (with the existing bundled-prettier fallback if they--omit=optional).Test plan
npm run buildpassesnpm run typecheckpassesnode_modules/prettierbefore this change reproduces the exact 9 TS2307 errors from CI; after this change, prettier is reinstalled bynpm installas a devDep so the failure can't recur