Skip to content

Go: mutate objects in place in RPC receiver#7785

Merged
greg-at-moderne merged 1 commit into
mainfrom
greg-go-rpc-empty-kind-fix
May 26, 2026
Merged

Go: mutate objects in place in RPC receiver#7785
greg-at-moderne merged 1 commit into
mainfrom
greg-go-rpc-empty-kind-fix

Conversation

@greg-at-moderne
Copy link
Copy Markdown
Contributor

@greg-at-moderne greg-at-moderne commented May 26, 2026

What's changed?

Change the RPC visitor implementation for Go. Mutate the objects in place, just like we do for other languages.

What's your motivation?

Otherwise the recipe run might fail with:

java.lang.IllegalArgumentException: No enum constant org.openrewrite.java.tree.JavaType.FullyQualified.Kind.
  at org.openrewrite.java.tree.JavaType$FullyQualified$Kind.valueOf(JavaType.java:389)
  at org.openrewrite.java.internal.rpc.JavaTypeReceiver.lambda$visitClass$7(JavaTypeReceiver.java:74)

if you have a cycle in type attributions.

@greg-at-moderne greg-at-moderne self-assigned this May 26, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite May 26, 2026
@greg-at-moderne greg-at-moderne marked this pull request as ready for review May 26, 2026 13:41
@greg-at-moderne greg-at-moderne merged commit d2f7809 into main May 26, 2026
1 of 2 checks passed
@greg-at-moderne greg-at-moderne deleted the greg-go-rpc-empty-kind-fix branch May 26, 2026 13:41
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenRewrite May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant