TypeTable: tolerate cross-JVM races when publishing per-artifact JARs#7786
Merged
Conversation
Since #7528 switched TypeTable to write per-artifact JARs via `Files.move(tmpJar, jarPath, ATOMIC_MOVE, REPLACE_EXISTING)`, parallel Gradle test forks sharing `~/.rewrite/classpath/.tt/...` could fail on Windows with AccessDeniedException when one JVM tried to replace a jar that another JVM had open. Drop REPLACE_EXISTING (the jar contents are deterministic, so the existing file is fine) and catch FileAlreadyExistsException / AccessDeniedException, falling back to the existing jar on disk. Adds a regression test that simulates a fresh JVM by clearing the in-process map between two reads.
knutwannheden
approved these changes
May 27, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaTypeFactoryand extendJavaSourceSetwith classpath fast paths #7528 switchedTypeTablefrom writing per-class files to publishing a single per-artifact JAR viaFiles.move(tmpJar, jarPath, ATOMIC_MOVE, REPLACE_EXISTING), parallel Gradle test forks sharing~/.rewrite/classpath/.tt/...could crash on Windows withAccessDeniedExceptionwhen one JVM tried to replace a jar that another JVM had open. This dropsREPLACE_EXISTING(the jar contents are deterministic, so the existing file is fine) and catchesFileAlreadyExistsException/AccessDeniedException, accepting the on-disk jar produced by the other process and cleaning up our temp file. A regression test simulates a fresh JVM by reflectively clearing the in-processjarByArtifactmap between two reads.Test plan
./gradlew :rewrite-java:test --tests TypeTableTest