C#: preserve whitespace in nullable directives and widen IsPattern#7787
Merged
Conversation
Preserves the original whitespace between `#nullable` and the setting keyword (e.g. `#nullable enable`) via a new `keywordSpacing` field on `NullableDirective`. Widens `Cs.IsPattern.Pattern` from `Pattern` to `Expression` so parenthesized patterns (`J.Parentheses<Expression>`) and wrapped declaration patterns fit too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#nullableand the setting keyword (e.g.#nullable enable) via a newkeywordSpacingfield onCs.NullableDirective, threaded through the parser, printer, and RPC sender/receiver on both the Java and C# sides.Cs.IsPattern.PatternfromPatterntoExpressionso parenthesized patterns (J.Parentheses<Expression>) and wrapped declaration patterns fit too; parser now usesVisitPatternAsExpression.Test plan
./gradlew :rewrite-csharp:testdotnet testagainstrewrite-csharp/csharp