C#: preserve whitespace in auto-property accessors and null-conditional assignments#7803
Merged
Conversation
…al assignments - Model auto-implemented accessors (e.g. `get ;`) by storing a J.Empty in AccessorDeclaration.ExpressionBody whose Prefix carries the whitespace between the keyword and the trailing ';'. Printer emits ';' without '=>' when the body element is Empty. - Extend ApplyConditionalAccessPrefix to cover Assignment, AssignmentOperation, and CsUnary segments so null-conditional targets (e.g. `rgb?.Length = 0`, `Changed -= OnChanged`) keep their leading whitespace on round-trip. - Add regression tests for both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get ;now round-trip:AccessorDeclaration.ExpressionBodyholds aJ.EmptywhosePrefixcarries the whitespace between the keyword and the trailing;. The printer treats anEmptybody element as the auto-impl signal and emits;without=>.Assignment,AssignmentOperation, orCsUnary(e.g.rgb?.Length = 0,Changed -= OnChanged) now keep their leading whitespace by routing through a sharedApplyConditionalAccessPrefixhelper.Test plan
dotnet testcovering the newAutoPropertyWithSpaceBeforeSemicolon,NullConditionalPropertyAssignmentPreservesLeadingNewline, andNullConditionalEventUnsubscribePreservesLeadingNewlinecases