Skip to content

Remove releases download, we don't need it any more #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bloodearnest merged 1 commit into from
Jun 17, 2025
Merged

Remove releases download, we don't need it any more #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ci-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,6 @@ assert-header 'Content-Type: text/plain; charset=UTF-8'
try github-proxy.opensafely.org/bloodearnest.keys 200
assert-in-body ed25519

# test download
try github-proxy.opensafely.org/opensafely-core/backend-server/releases/download/v0.1/test-download 200
assert-in-body test

### docker-proxy.opensafely.org ###

# test the initial docker request is rewritten correctly
Expand Down
14 changes: 0 additions & 14 deletions github.com.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,20 +59,6 @@ server {
proxy_ssl_server_name on;
}

# allow release artifacts to be downloaded from specified repo only
location ~ ^/opensafely-core/backend-server/releases/download {
limit_except GET { deny all; }
proxy_pass https://github.com;
proxy_redirect default;
# ensure Host header and SNI domain match
proxy_ssl_server_name on;
# `releases/download` redirects to an S3 bucket, which is not accessible from
# backends. So handle redirects to S3 here in the proxy rather than
# passing back to the client
proxy_intercept_errors on;
error_page 301 302 307 = @handle_redirect;
}

location @handle_redirect {
# set saves the initial response's Location: header
set $redirect '$upstream_http_location';
Expand Down