Upgrade to latest repo template/uv #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the Dockerfile to follow the repo-template version. Avoid needing to copy uv into the prod image by running the prod entrypoint with just python, not uv run. We're running in the venv created with uv, using the python version we installed with deadsnakes, so just python should do the right thing. Use --frozen rather than --locked to use the uv.lock file as it is. Also run the tests in the dev entrypoint without uv; dependencies are installed inthe docker image and we don't need/want it to re-sync every time
madwort
reviewed
Nov 7, 2025
| # See https://github.com/opensafely-core/repo-template/blob/main/DEVELOPERS.md for details | ||
| [tool.uv] | ||
| exclude-newer = "2025-10-27T00:00:00Z" | ||
| required-version = ">=0.9" |
Contributor
There was a problem hiding this comment.
ah! I needed this yesterday in the ehrQL repo!
Contributor
Author
There was a problem hiding this comment.
Yeah, I only added it in this repo because the UV version was specified in places, but maybe it should be in the repo-template too
madwort
reviewed
Nov 7, 2025
DEVELOPERS.md
Outdated
| ```bash | ||
| # build the image | ||
| docker build . -t tpp-database-utils | ||
| just build-docker |
Contributor
There was a problem hiding this comment.
this needs to be
just docker/build
Contributor
There was a problem hiding this comment.
ah this is done in a later commit!
madwort
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19