Merged
Conversation
We now have to set the pyenv installed python as the system python so opensafely-cli will be on the path once installed.
lucyb
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes pipx from the macOS installation docs since opensafely-cli has no dependencies and the primary use of pipx is to provide a place to install python tools with dependencies without using your global python env.
This does add a possible risk for future maintenance in that we're now telling users to configure pyenv such it should take priority over a homebrewed or system python. While this is considered the correct way to install Python on macOS (because homebrew and system pythons can be updated out from under you), my concern is that it ends up with further burden on our tech support. The pipx method used the pyenv-installed python but didn't put it on ones path. This is probably fine, but if we see any issues with it I think it makes sense to switch back to the pipx method.
Fixes: #1026