Fix problems with Speaker CSS#38
Merged
duduribeiro merged 1 commit intomasterfrom Apr 19, 2018
Merged
Conversation
duduribeiro
approved these changes
Apr 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
Houve alguns conflitos devido algumas classes de bootstrap, em alguma dimensões as medidas da imagem e comprimento dos wrappers dos speakers conflitavam jogando as colunas pra frente.
Detalhamento para aprendizagens futuras
max-widthela vai se limitar ao tamanho maximo da media que foi carregada (algumas fotos tinha max de 270px/350px) não acompanhando as demais.Solução
min-heightao tamanho do wrappers para algumas dimensões evitando a quebra do layout do bootstrapwidth: 100%na imagem para ela "estrapolar" o max-width