Skip to content

Fix npm publish github action#349

Merged
MatiasOS merged 1 commit into
openscan-explorer:mainfrom
MatiasOS:update-npm-publish
Mar 26, 2026
Merged

Fix npm publish github action#349
MatiasOS merged 1 commit into
openscan-explorer:mainfrom
MatiasOS:update-npm-publish

Conversation

@MatiasOS

Copy link
Copy Markdown
Member

Description

Fix npm publish CI workflow failing with ENEEDAUTH by bumping GitHub Actions to v5, matching the working workflows in other openscan repos.

Related Issue

Fixes failing Publish to npm workflow run.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Performance improvement
  • Other (please describe):

Changes Made

  • Bumped actions/checkout from v4 to v5
  • Bumped actions/setup-node from v4 to v5

Screenshots (if applicable)

Checklist

  • I have run npm run format:fix and npm run lint:fix
  • I have run npm run typecheck with no errors
  • I have run tests with npm run test:run
  • I have tested my changes locally
  • I have updated documentation if needed
  • My code follows the project's architecture patterns

Additional Notes

The v5 versions properly support OIDC (Trusted Publishing) for npm authentication. The v4 versions were not wiring the OIDC token correctly, causing ENEEDAUTH errors during npm publish. This aligns the explorer workflow with the working workflows in network-connectors, hardhat-plugin, and explorer-metadata.

The other openscan repos (network-connectors, hardhat-plugin, explorer-metadata) already use v5 for both actions and publish successfully with OIDC authentication.

@github-actions

Copy link
Copy Markdown

🚀 Preview: https://pr-349--openscan.netlify.app
📝 Commit: 61b6cae06549e23a0c9cbb452ed8d5191b3472c3

@josealoha666 josealoha666 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward bump of actions/checkout and actions/setup-node from v4 → v5.

@MatiasOS MatiasOS requested a review from AugustoL March 26, 2026 17:40
@MatiasOS MatiasOS merged commit a49cbae into openscan-explorer:main Mar 26, 2026
7 of 11 checks passed
@MatiasOS MatiasOS deleted the update-npm-publish branch March 26, 2026 17:59
@AugustoL AugustoL mentioned this pull request Apr 29, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants